You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We don't want to show the progress bar for only part of the process on HSA. To handle this, we recommend removing the progress bar from the base for now and moving it into HMASynthesizer.
Expected behavior
Remove verbose argument from BaseMultiTableSynthesizer
Only show the progress bar in HMA
Additional context
Right now the base preprocess method uses the progress bar when applicable. https://github.com/sdv-dev/SDV/blob/master/sdv/multi_table/base.py#L322-L323
One suggestion could be to make _get_pbar_args return a disabled progress bar and just override it in HMASynthesizer to use the verbose argument. This way we don't have to move much code around
The text was updated successfully, but these errors were encountered:
Problem Description
We don't want to show the progress bar for only part of the process on HSA. To handle this, we recommend removing the progress bar from the base for now and moving it into
HMASynthesizer
.Expected behavior
BaseMultiTableSynthesizer
Additional context
https://github.com/sdv-dev/SDV/blob/master/sdv/multi_table/base.py#L322-L323
One suggestion could be to make
_get_pbar_args
return a disabled progress bar and just override it inHMASynthesizer
to use the verbose argument. This way we don't have to move much code aroundThe text was updated successfully, but these errors were encountered: