Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample by default the same number of rows as in the original table #163

Closed
csala opened this issue Jul 2, 2020 · 0 comments · Fixed by #164
Closed

Sample by default the same number of rows as in the original table #163

csala opened this issue Jul 2, 2020 · 0 comments · Fixed by #164
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@csala
Copy link
Contributor

csala commented Jul 2, 2020

Current version samples 5 rows by default when no explicit number is passed.

Let's store the number of rows that were passed in the original tables and sample that number by default.

Note that, if sample is used, the default number of sampled rows will be the same as in the corresponding original table, but if sample_all is used, only the parent tables will have the same number of rows, as the number of rows in the children table will also be sampled.

@csala csala self-assigned this Jul 2, 2020
@csala csala added the feature request Request for a new feature label Jul 2, 2020
@csala csala added this to the 0.3.4 milestone Jul 2, 2020
@csala csala closed this as completed in #164 Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant