You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, almost all synthesizers have a method called get_parameters and there is some inconsistency between what is returned here. Let's align the return value of this function to the overall synthesizer representation.
Expected behavior
The parameters of a synthesizer are the optional input values during instantiation, excluding items such as the metadata, constraints, preprocessing, or individual table-level synthesizers.
For all synthesizers: The get_parameters call should include all optional settings during instantiation. They should include all of the optional settings.
If a user inputted them, include the user-inputted value
If a user did not input a setting, include the default value
Add the get_parameters call to the SingleTablePreset (with parameters 'name' and 'locales')
For multi-table synthesizer, only include the top-level parameters for the multi-table algorithm
Same a (1), include all settings during instantiation, even the default ones
Do not include the 'tables' dictionary. We will re-establish a different call to get these values.
Make an exception for the single table DayZSynthesizer: This synthesizer should continue to include the 'columns' dictionary with instructions for how to make each column -- including default values.
Problem Description
Currently, almost all synthesizers have a method called
get_parameters
and there is some inconsistency between what is returned here. Let's align the return value of this function to the overall synthesizer representation.Expected behavior
The parameters of a synthesizer are the optional input values during instantiation, excluding items such as the metadata, constraints, preprocessing, or individual table-level synthesizers.
get_parameters
call should include all optional settings during instantiation. They should include all of the optional settings.get_parameters
call to the SingleTablePreset (with parameters'name'
and'locales'
)'tables'
dictionary. We will re-establish a different call to get these values.DayZSynthesizer
: This synthesizer should continue to include the'columns'
dictionary with instructions for how to make each column -- including default values.Additional Context
The text was updated successfully, but these errors were encountered: