Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add add-on modules to sys.modules #1924

Closed
amontanez24 opened this issue Apr 17, 2024 · 0 comments · Fixed by #1929
Closed

Add add-on modules to sys.modules #1924

amontanez24 opened this issue Apr 17, 2024 · 0 comments · Fixed by #1929
Assignees
Labels
internal The issue doesn't change the API or functionality
Milestone

Comments

@amontanez24
Copy link
Contributor

Problem Description

As a user, it would be useful if importing for premium features worked the same as for public features.

Expected behavior

For some premium features, we want to add modules that don't exist and be able to import from them.

from sdv.new_module import NewClass

Currently this is not supported. To fix this, we need to add the new modules to sys.modules, since that is the dict python uses for imports.

@amontanez24 amontanez24 added the feature request Request for a new feature label Apr 17, 2024
@amontanez24 amontanez24 added this to the 1.12.1 milestone Apr 17, 2024
@amontanez24 amontanez24 self-assigned this Apr 19, 2024
@amontanez24 amontanez24 added internal The issue doesn't change the API or functionality and removed feature request Request for a new feature labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant