Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample parameter to control reject sampling crash #343

Closed
fealho opened this issue Mar 17, 2021 · 0 comments · Fixed by #352
Closed

Add sample parameter to control reject sampling crash #343

fealho opened this issue Mar 17, 2021 · 0 comments · Fixed by #352
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@fealho
Copy link
Member

fealho commented Mar 17, 2021

Problem Description

Add an argument to sample (e.g. graceful_reject_sampling), which would default to False, that controls whether it should crash if no rows can be sampled within a given number of iterations or just return them with a warning.

  • If the user passes False (which would be the default) it would raise an exception like it currently does.
  • If the user passes True, and if it is not possible to generate all the requested rows, it would just issue a warning and return whatever it was able to generate except in the case in which it was not able to generate any valid row at all, in which an exception would also be raised.
@fealho fealho added feature request Request for a new feature pending review and removed pending review labels Mar 17, 2021
@pvk-developer pvk-developer added this to the 0.9.0 milestone Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants