Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GreaterThan Constraint should apply to scalars #410

Closed
kveerama opened this issue Apr 21, 2021 · 2 comments
Closed

GreaterThan Constraint should apply to scalars #410

kveerama opened this issue Apr 21, 2021 · 2 comments
Assignees
@amontanez24
Labels
feature request Request for a new feature
Milestone
0.11.0

Comments

@kveerama
Copy link
Contributor

kveerama commented Apr 21, 2021 •
edited

In our discussion, it came up that GreaterThan constraint may be interpreted as a constraint that allows user to specify a value that a column should be GreaterThan. Instead it is a logical comparison between two columns. Perhaps we should see if we can rename this constraint.
@kveerama kveerama added question General question about the software pending review labels Apr 21, 2021
@amontanez24
Copy link
Contributor

resolved by #485

@npatki npatki modified the milestone: 0.11.0 Jul 7, 2021
@npatki npatki changed the title Should we consider renaming the GreaterThan constraint GreaterThan Constraint should apply to scalars Jul 7, 2021
@npatki
Copy link
Contributor

npatki commented Jul 7, 2021

We're solving this issue by allowing GreaterThan to accept both scalars and column comparisons.

@npatki npatki added this to the 0.11.0 milestone Jul 7, 2021
@npatki npatki added feature request Request for a new feature and removed question General question about the software labels Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amontanez24 amontanez24

Labels
feature request Request for a new feature
Projects
None yet
Milestone
0.11.0
Development

No branches or pull requests
3 participants
@kveerama @npatki @amontanez24