Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reject sampling to sample missing columns for constraints #435

Closed
amontanez24 opened this issue May 20, 2021 · 0 comments · Fixed by #475
Closed

Use reject sampling to sample missing columns for constraints #435

amontanez24 opened this issue May 20, 2021 · 0 comments · Fixed by #475
Assignees
Labels
bug Something isn't working
Milestone

Comments

@amontanez24
Copy link
Contributor

Problem Description:

Right now, the rows sampled by the constraint's column_model aren't guaranteed to be valid. For example, in the case of the GreaterThan constraint, if the smaller column is provided, the column_model will conditionally sample the larger column value. In some cases, it may sample a smaller value, which would mean that the conditions used are wrong and the conditional sampling will always fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants