Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presets should be able to handle constraints #753

Closed
npatki opened this issue Mar 30, 2022 · 0 comments · Fixed by #755
Closed

Presets should be able to handle constraints #753

npatki opened this issue Mar 30, 2022 · 0 comments · Fixed by #755
Assignees
@katxiao
Labels
feature request Request for a new feature
Milestone
0.14.1

Comments

@npatki
Copy link
Contributor

npatki commented Mar 30, 2022

Problem Description

In #716 we defined the preset functionality. Let's also add in the ability to input constraints in this preset.

  • Right now, both metadata & constraints cannot be input into a tabular model. The user can supply either-or
  • If the user wishes to add constraints, they have to put it into the metadata, which is not straighforward

For for now, we should allow users to input their constraints as a separate parameter for presets only.
@npatki npatki added the feature request Request for a new feature label Mar 30, 2022
@katxiao katxiao self-assigned this Mar 31, 2022
@katxiao katxiao mentioned this issue Mar 31, 2022
Merged
@katxiao katxiao added this to the 0.14.1 milestone May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katxiao katxiao

Labels
feature request Request for a new feature
Projects
None yet
Milestone
0.14.1
Development

Successfully merging a pull request may close this issue.

Add constraints to preset sdv-dev/SDV
2 participants
@katxiao @npatki