Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model nulls normally when tabular preset has constraints #764

Merged
merged 3 commits into from
Apr 19, 2022

Conversation

katxiao
Copy link
Contributor

@katxiao katxiao commented Apr 14, 2022

Resolves #763

If tabular preset has constraints, model nulls normally instead of pre- and post-processing the data. Also, update the preset name.

@katxiao katxiao requested a review from a team as a code owner April 14, 2022 21:32
@katxiao katxiao requested review from pvk-developer and removed request for a team April 14, 2022 21:32
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2022

Codecov Report

Merging #764 (af13ae9) into master (63c01dd) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #764      +/-   ##
==========================================
+ Coverage   67.79%   67.85%   +0.05%     
==========================================
  Files          38       38              
  Lines        2863     2868       +5     
==========================================
+ Hits         1941     1946       +5     
  Misses        922      922              
Impacted Files Coverage Δ
sdv/lite/tabular.py 98.55% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63c01dd...af13ae9. Read the comment docs.

Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment about adding test cases. Otherwise LGTM!

sdv/lite/tabular.py Show resolved Hide resolved
@katxiao katxiao merged commit 1a94dce into master Apr 19, 2022
@katxiao katxiao deleted the issue-763-tabular-preset-with-constraints branch April 19, 2022 19:10
@katxiao katxiao added this to the 0.14.1 milestone May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabular Preset with constraints should handle nulls correctly
4 participants