Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve datetime handling in ScalarInequality and ScalarRange constraints #819

Closed
amontanez24 opened this issue May 24, 2022 · 0 comments · Fixed by #853
Closed

Improve datetime handling in ScalarInequality and ScalarRange constraints #819

amontanez24 opened this issue May 24, 2022 · 0 comments · Fixed by #853
Labels
feature request Request for a new feature
Milestone

Comments

@amontanez24
Copy link
Contributor

Problem Description

As a user, it would be useful if I could provide my datetime value as a string for the ScalarInequality and ScalarRange constraints. The synthetic data in the end should also match the same format as the input data.

Expected behavior

  • Enforce that string values are used to define datetimes for the value parameter of the ScalarInequality constraint and the low_value and high_value parameters of the ScalarRange constraints.
  • Enforce that the data after reverse_transform is in the same datetime format as the data that was fitted.
  • Investigate the log warning that sometimes occurs when there are null values in the datetime column.

Additional context

  • For the warning, investigate the cause. If it is a simple fix, implement in this issue, otherwise file another issue.
@amontanez24 amontanez24 added feature request Request for a new feature pending review labels May 24, 2022
@amontanez24 amontanez24 changed the title Imporive datetime handling in ScalarInequality and ScalarRange constraints Improve datetime handling in ScalarInequality and ScalarRange constraints May 24, 2022
@pvk-developer pvk-developer added this to the 0.16.0 milestone Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants