Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot use max_tries_per_batch on sample: TypeError: sample() got an unexpected keyword argument 'max_tries_per_batch' #885

Closed
npatki opened this issue Jul 8, 2022 · 0 comments · Fixed by #899
Closed

Cannot use max_tries_per_batch on sample: TypeError: sample() got an unexpected keyword argument 'max_tries_per_batch' #885

npatki opened this issue Jul 8, 2022 · 0 comments · Fixed by #899
Labels
bug Something isn't working data:single-table Related to tabular datasets feature:sampling Related to generating synthetic data after a model is built
Milestone
0.16.0

Comments

@npatki
Copy link
Contributor

npatki commented Jul 8, 2022 •
edited
Loading

Environment Details

  • SDV version: 0.16.0.dev1

Error Description

For any tabular model (I tested GaussianCopula and CTGAN), the max_tries_per_batch parameter cannot be used on the general sample method.

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
[<ipython-input-39-3237679d016c>](https://localhost:8080/#) in <module>()
----> 1 s = model.sample(num_rows=20000, batch_size=100, max_tries_per_batch=2)

TypeError: sample() got an unexpected keyword argument 'max_tries_per_batch'
@npatki npatki added bug Something isn't working new Automatic label applied to new issues data:single-table Related to tabular datasets feature:sampling Related to generating synthetic data after a model is built labels Jul 8, 2022
@npatki npatki changed the title TypeError: sample() got an unexpected keyword argument 'max_tries_per_batch' Cannot use max_tries_per_batch on sample: TypeError: sample() got an unexpected keyword argument 'max_tries_per_batch' Jul 8, 2022
@npatki npatki removed the new Automatic label applied to new issues label Jul 8, 2022
@amontanez24 amontanez24 mentioned this issue Jul 11, 2022
Merged
@pvk-developer pvk-developer added this to the 0.16.0 milestone Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working data:single-table Related to tabular datasets feature:sampling Related to generating synthetic data after a model is built
Projects
None yet
Milestone
0.16.0
Development

Successfully merging a pull request may close this issue.

Cannot use max_tries_per_batch on sample sdv-dev/SDV
2 participants
@npatki @pvk-developer