Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove need for data in Gaussian Copula Sample #49

Closed
amontanez24 opened this issue Aug 21, 2018 · 1 comment
Closed

Remove need for data in Gaussian Copula Sample #49

amontanez24 opened this issue Aug 21, 2018 · 1 comment
Labels
internal The issue doesn't change the API or functionality

Comments

@amontanez24
Copy link
Collaborator

The sample method for a gaussian copula currently requires a that the data attribute exist. This is not correct since a user should be able to create a copula by just setting the parameters and still sample.

This is on line 91 and 92 of the gaussian copula file.
@ManuelAlvarezC ManuelAlvarezC added this to the 0.2.0 milestone Aug 22, 2018
@csala csala modified the milestones: 0.2.0, 0.1.1, 0.2.1 Aug 23, 2018
@ManuelAlvarezC ManuelAlvarezC added the internal The issue doesn't change the API or functionality label Sep 24, 2018
@ManuelAlvarezC ManuelAlvarezC removed this from the 0.2.1 milestone Jan 4, 2019
@ManuelAlvarezC
Copy link
Contributor

This is already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@csala @amontanez24 @ManuelAlvarezC