Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run_on_ec2 flag to benchmark_single_table #265

Closed
amontanez24 opened this issue Feb 26, 2024 · 0 comments · Fixed by #272
Closed

Add run_on_ec2 flag to benchmark_single_table #265

amontanez24 opened this issue Feb 26, 2024 · 0 comments · Fixed by #272
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@amontanez24
Copy link
Contributor

amontanez24 commented Feb 26, 2024

Problem Description

As a user, sometimes the benchmark function take a while and a lot of compute resources so it would be nice to be able to run it on a separate instance.

Expected behavior

  • Add run_on_ec2 boolean parameter to benchmark_single_table
  • If it is True
    1. Launch an ec2 instance
    2. Install sdgym on that instance
    3. Run the job on that instance with the rest of the parameters
    4. Store the output in an S3 folder based on the value of output_filepath

Technical Details

  • output_filepath is required to be an s3 bucket if the flag is enabled. We should add a check for that
  • We should do this using boto3 directly. They have a function called run_instances that can take in a script. In our case, we just want the script to pip install sdgym and then run the cli with the commands provided in the method above
@amontanez24 amontanez24 added feature request Request for a new feature under discussion Issue is currently being discussed and removed under discussion Issue is currently being discussed labels Feb 26, 2024
@amontanez24 amontanez24 added this to the 0.7.1 milestone May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants