Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of epochs does not match your homepage docs and example #37

Open
tirthajyoti opened this issue Sep 9, 2019 · 2 comments
Open
Labels
approved The issue is approved and someone can start working on it documentation This requires documentation changes

Comments

@tirthajyoti
Copy link

tirthajyoti commented Sep 9, 2019

Hi,

Thanks for this excellent implementation. I am trying it out now.
Your homepage docs and the Jupyter notebook example say max_epoch=100 but in fact, in the latest install, it is set to 5.

Please reconcile the descriptions. The model is computationally heavy, so it is good to have a realistic expectation about the epochs to run before one starting fitting :-)

@csala
Copy link
Contributor

csala commented Sep 16, 2019

Thanks for pointing this out @tirthajyoti !

We'll change the notebook and README asap to match the code (unless you want to do a PR that changes it ;-)

@csala csala added approved The issue is approved and someone can start working on it documentation This requires documentation changes labels Sep 16, 2019
@MariamDundua
Copy link

Does five epoch is enough for 2000000x20 size dataframe? What is recommended one for this size of dataframe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved The issue is approved and someone can start working on it documentation This requires documentation changes
Projects
None yet
Development

No branches or pull requests

3 participants