Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random search crash at the end? due to NaN ? on classifier.fit(..) #47

Open
nevermindthat opened this issue Oct 26, 2019 · 1 comment
Open

Comments

@nevermindthat
Copy link

nevermindthat commented Oct 26, 2019

Hi,

Thanks for the great paper and code!.

  1. I'm trying to reproduce your results for census and covertype datasets, i wasn't able with the out of the box settings, so i tried your random search but ran into this issue.
    This issue is about that.

  2. I would love to know your parameters settings for census data and covertype.
    As they weren't mentioned.

  3. Also where can i find the preprocessing code for these datasets as the given ones
    http://hdi-project-tgan.s3.amazonaws.com/index.html
    Have already been processed. There's also no test split - where can i find it? it's not in the link provided.
    The section: https://dai-lab.github.io/TGAN/readme.html#input-format
    Only say:

The input data for this fitting process has to be a single table that satisfies the following rules:
Has no missing values.
Has columns of types int, float, str or bool.
Each column contains data of only one type.

How did you impute data if was missing? what scaling you've used, etc.. as i'm trying to reproduce.

  1. I didn't see the discriminator converges to "fake accuracy" 0.5 and "real accuracy" 0.5 at any of my runs. How come? tried to read here in issues, the papers, code.. how come?

Python version: 3.5.3
Operating System: 4.9.0-9-amd64 #1 SMP Debian 4.9.168-1+deb9u4 (2019-07-19) x86_64 GNU/Linux - on GCP
TensorFlow version: 1.14.0

nvcc: NVIDIA (R) Cuda compiler driver Copyright (c) 2005-2018 NVIDIA Corporation Built on Sat_Aug_25_21:08:01_CDT_2018 Cuda compilation tools, release 10.0, V10.0.130
GPU:
image

Description

I've ran
tgan experiments config_hpo.json results.jsons
This was the outcome:

image

What I Did

config_hpo.json looks:
image

Seems this is the line that raises the error because of NaN ?
https://github.com/DAI-Lab/TGAN/blob/51243cc705046538683d41738d1bb9cd22871f03/tgan/research/evaluation.py#L68

Thank you!

@devmehta01
Copy link

@nevermindthat how did you make "tgan experiments config_hpo.json results.jsons" line work? For me it just says invalid syntax. what was your code before this line? I will just add my code below, please let me know what changes i need to make.

!git clone https://github.com/sdv-dev/TGAN.git

cd TGAN

!make install-develop

!pip uninstall tensorflow
!pip install "tensorflow-gpu>=1.13.0,<2.0"

import pandas as pd
data = pd.read_csv("dataset_linux_driver_net_new.csv") #I am using my own dataset

continuous_columns = [x for x in range(83)] #It has 83 continuous columns
continuous_columns

from tgan.model import TGANModel
tgan = TGANModel(continuous_columns)

tgan experiments config.json results.json #config.json exists in the main TGAN directory & not under examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants