We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello @se-panfilov, thanks for creating this package.
I noticed that your makeCss function has a small bug that causes it to incorrectly parse the value of multi-word css rules.
makeCss
For example, if I provide this message style override in the config object:
'.mini-toastr-notification__message': { display: 'inline-block', 'vertical-align': 'middle', width: '240px', 'white-space': 'pre-wrap', },
it will be parsed like so:
the problem is this line:
.replace(/(\w*-?\w*): ([\w\d .#]*),?/g, '$1: $2;')
it needs to also look for - chars. ie, it should be changed to:
-
.replace(/(\w*-?\w*): ([\w\d .#-]*),?/g, '$1: $2;')
then the css is parsed as expected:
Happy to open a PR for this but it looks like I don't have permission 🙏
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hello @se-panfilov, thanks for creating this package.
I noticed that your
makeCss
function has a small bug that causes it to incorrectly parse the value of multi-word css rules.For example, if I provide this message style override in the config object:
it will be parsed like so:
the problem is this line:
it needs to also look for
-
chars. ie, it should be changed to:then the css is parsed as expected:
Happy to open a PR for this but it looks like I don't have permission 🙏
The text was updated successfully, but these errors were encountered: