Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sel4test compile action #73

Closed
lsf37 opened this issue Jun 21, 2021 · 3 comments · Fixed by #123
Closed

sel4test compile action #73

lsf37 opened this issue Jun 21, 2021 · 3 comments · Fixed by #123
Assignees
Labels
sel4test actions for sel4test and related repos

Comments

@lsf37
Copy link
Member

lsf37 commented Jun 21, 2021

Not entirely clear if we want this.

On bamboo we had this for all PRs. I would actually prefer to go one step further on PRs and automatically run all of the simulation tests (but trigger hardware tests manually).

@lsf37 lsf37 added the sel4test actions for sel4test and related repos label Jun 21, 2021
@lsf37 lsf37 added this to To Do in Bamboo replacement via automation Jun 21, 2021
@axel-h
Copy link
Member

axel-h commented Jun 21, 2021

I think this makes sense.

@pingerino
Copy link

As long as simulation doesn't try and run if the kernel doesn't compile. This is why we staged it. Also not all targets are simulate-able, but we want to make sure they compile.

@lsf37
Copy link
Member Author

lsf37 commented Jun 21, 2021

As long as simulation doesn't try and run if the kernel doesn't compile. This is why we staged it. Also not all targets are simulate-able, but we want to make sure they compile.

Bamboo currently has 4 stages, 2 for simulation targets (build + simulate) and 2 for hardware targets (build + simulate). The idea would be to fuse the build and run stage for simulate, but not hardware, i.e.:

  • if armv7-simulate build does not work, it won't try to simulate, but if the armv8-simulate build succeeded for the same kernel, it would simulate that one.
  • if any simulate run (or build) didn't work, the HW test would not trigger unless started manually

For the hardware test we probably want to keep it staged as we have it on Bamboo to keep down the load on the machine queue, i.e. it should only run any actual hardware test if all of the hardware builds succeeded.

@lsf37 lsf37 moved this from To Do to In Implementation in Bamboo replacement Jul 2, 2021
@lsf37 lsf37 self-assigned this Jul 5, 2021
@lsf37 lsf37 linked a pull request Jul 16, 2021 that will close this issue
@lsf37 lsf37 moved this from In Implementation to Testing/Review in Bamboo replacement Jul 16, 2021
Bamboo replacement automation moved this from Testing/Review to Done Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sel4test actions for sel4test and related repos
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants