Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm mode line is mixedly active/inactive when previewing a line #200

Closed
lerouxrgd opened this issue Jul 24, 2019 · 11 comments
Closed

Helm mode line is mixedly active/inactive when previewing a line #200

lerouxrgd opened this issue Jul 24, 2019 · 11 comments
Labels
bug Something isn't working

Comments

@lerouxrgd
Copy link

lerouxrgd commented Jul 24, 2019

Describe
When previewing a line from an Helm buffer, if the modeline has different background colors for active/inactive, then they will be mixed up.
The parts of the modeline having Helm text appear as active, and the rest as inactive.

Steps and Expected
The whole Helm modeline should appear either as active or inactive.

Environment:

  • OS: Arch GNU/Linux and Emacs doom-themes

Additional context
See an example of previewing an LSP match (xref) in Doom Nova theme:
image

@seagle0128 seagle0128 added the bug Something isn't working label Jul 24, 2019
@seagle0128
Copy link
Owner

Please test the latest version.

@lerouxrgd
Copy link
Author

It fixed it for Helm modeline, thank you !

Just a small detail, I realized the same thing happens when closing Emacs while an active process is still running:
image

@seagle0128
Copy link
Owner

Unfortunately I cannot reproduce this issue locally. Would you please provide details?

@lerouxrgd
Copy link
Author

So I get this if I have an active process running, like a shell started with M-x shell, and then from a regular file buffer I try to quit Emacs with C-x C-c, it will prompt the regular message Active processes exist; kill them and exit anyway and the focus will be on the minibuffer.
At this moment the modeline is displayed mixedly active/inactive.

@seagle0128
Copy link
Owner

seagle0128 commented Jul 25, 2019

I suppose you are using doom-nova, right? And what's the Emacs version? I am using Emacs 27.0.50 on macOS, and couldn't reproduce this issue.
Another question is why the process buffer is displayed while killing the Emacs as below?

image

@lerouxrgd
Copy link
Author

Yes I am using doom-nova, Emacs version 26.2 on Arch Linux.

The buffer displaying the process to kill actually appeared on the next window, and I didn't include it on my last picture.
If I force it to appear on the same window it is as follows:
Screenshot_20190725_183653

@seagle0128
Copy link
Owner

I still couldn't reproduce on macOS and Linux Mint. Can you try Emacs 27?

@cyruseuros
Copy link

I'm not sure if I'm experiencing something similar here. The elisp fileicon in helm is now always white, and never purple like it used to be.

@seagle0128
Copy link
Owner

@jjzmajic f541215 has been committed. The color is changed to blue for helm.

@cyruseuros
Copy link

Any way to change it back without redefining the whole segment?

@seagle0128
Copy link
Owner

@jjzmajic No need any change from user side. Just update the package to the latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants