Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom face for the LSP icon #203

Closed
futile opened this issue Aug 1, 2019 · 4 comments
Closed

Custom face for the LSP icon #203

futile opened this issue Aug 1, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@futile
Copy link

futile commented Aug 1, 2019

Is your feature request related to a problem? Please describe.
There is currently no way to specify a face used for the lsp-icon, as it uses either success or warning (see https://github.com/seagle0128/doom-modeline/blob/master/doom-modeline-segments.el#L1616).

Describe the solution you'd like
A new face that can be used to change the appearance of the lsp icon. Maybe two, one for working and one for not working, not sure what is best here.

Describe alternatives you've considered
Currently a workaround is changing success and warning directly, but this is suboptimal, as this is a more general adjustment than the one I want to express.

Additional context
None.

@seagle0128 seagle0128 added the enhancement New feature or request label Aug 1, 2019
@seagle0128
Copy link
Owner

I added doom-modeline-lsp-success, doom-modeline-lsp-warning and doom-modeline-lsp-error for the LSP icon, which supports both lsp-mode and eglot.

@futile
Copy link
Author

futile commented Aug 1, 2019

Wow, really quick! Thanks a lot, that 100% solves my issue :)

@andreyorst
Copy link

Sorry for bumping closed issue, but is it possible to change rocket icon to something else? Maybe allow user to set the icon through all-the-icons package?

@seagle0128
Copy link
Owner

@andreyorst No, I am not going to provide such customizations. But you can rewrite doom-modeline-lsp-icon to achieve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants