Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning about fancy-battery-mode #234

Closed
jsmestad opened this issue Oct 22, 2019 · 4 comments
Closed

Warning about fancy-battery-mode #234

jsmestad opened this issue Oct 22, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@jsmestad
Copy link
Contributor

jsmestad commented Oct 22, 2019

Describe
Installing emacs-plus 27.0.50 and installing doom-modeline on my MBP, I get an error from use-package

Error (use-package): doom-modeline/:config: Symbol’s value as variable is void: fancy-battery-last-status

Funny thing is, I do not use fancy-battery at all. Even after trying with fancy-battery installed, I get the same error, but the battery status shows up. 🤷‍♂️

Environment:

  • OS: macOS
  • Version: Mojave
  • Package version 20191022
@TakaakiFuruse
Copy link

TakaakiFuruse commented Oct 23, 2019

I had the same problem.

Mine is Mint Linux 19.02 and Spacemacs Dev. Looks like fancy-battery is called from doom-modeline and causing problem?

Is there any way to remove dependency of fancy-battery, because the library is not maintained anymore?

emacsorphanage/fancy-battery@9b88ae7

@seagle0128
Copy link
Owner

This is a regression issue. I will fix it soon.

@TakaakiFuruse Thank you for the information! I am thinking to drop fancy-battery-mode, and use built-in display-battery-mode instead.

@seagle0128 seagle0128 added the bug Something isn't working label Oct 23, 2019
@cyruseuros
Copy link

Dang that was fast. Thanks @seagle0128!

@TakaakiFuruse
Copy link

@seagle0128
Just applied your patch and confirmed that the problem is gone.
Thanks for your job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants