[Bug] Modeline Background gets Broken Up

[dylanjm]

Thank you for the bug report

• I am using the latest version of doom-mode related packages.
• I checked FAQ.
• You may also try reproduce the issue using clean environment and minimal configurations with
  the command emacs -Q.

Bug description

Sometimes the modeline background gets broken up and doesn't extend across the buffer all the way.

Steps to reproduce

This is my configuration for doom-modeline:

(use-package doom-modeline
  :straight t
  :ghook ('after-init-hook)
  :config
  (general-setq doom-modeline-buffer-encoding t
                doom-modeline-checker-simple-format t
                doom-modeline-hud t
                doom-modeline-project-detection 'projectile))

This is my configuration for all-the-icons:

(use-package all-the-icons
  :straight t
  :commands (all-the-icons-icon-for-buffer)
  :config
  (general-setq all-the-icons-scale-factor 1)
  (general-pushnew '("\\.db$" all-the-icons-faicon
                     "database" :face all-the-icons-blue)
                   all-the-icons-icon-alist)
  (general-pushnew '("\\.edn$" all-the-icons-alltheicon
                     "clojure" :face all-the-icons-green)
                   all-the-icons-icon-alist))

Expected behavior

To not have the break in modeline.

OS

MacOS

Emacs Version

gccemacs-28

Emacs Configurations

https://github.com/dylanjm/teton/tree/master/config/emacs

Error callstack

No response

Anything else

Expected Behavior

[seagle0128]

Can you please describe the detailed steps to reproduce?

[dylanjm]

Hi, I don't mean to be difficult, but short of commenting out my config line by line until I narrow down the problem -- I don't see how I could provide a more reproducible example than what I've provided up above in my issue.

Please advise if there is anything I could do to narrow down this problem more.

[seagle0128]

Sorry, no idea.

[GorrillaRibs]

I'm seeing this too now, it looks like it might be related to emacs 29 & the new mode-line-active face? It didn't show up for me until I started using emacs from git, and seems fine in emacs 28.

[GorrillaRibs]

After a bit of testing, reverting this commit fixes the visual bug, is there any way to work around this?

[seagle0128]

@GorrillaRibs I think you should report to emacs-dev. The commit is stupid and broke the things...

[tshu-w]

I have similar issue and fix with:

(set-face-attribute 'mode-line nil :inherit 'default)
(set-face-attribute 'mode-line-active nil :inherit 'mode-line)
(set-face-attribute 'mode-line-inactive nil :inherit 'mode-line)

[skyler544]

(set-face-attribute 'mode-line nil :inherit 'default)
(set-face-attribute 'mode-line-active nil :inherit 'mode-line)
(set-face-attribute 'mode-line-inactive nil :inherit 'mode-line)

this doesn't make any difference for me; I'm on the Emacs development branch. Minimal necessary configuration to reproduce:

(require 'package)
(add-to-list 'package-archives
             '("melpa" . "https://melpa.org/packages/") t)
(package-initialize)
(unless (package-installed-p 'use-package)
  (package-install 'use-package))
(eval-when-compile
  (require 'use-package))
(setq use-package-always-ensure t)

(use-package doom-modeline
  :config (doom-modeline-mode))

(use-package emacs
  :init
  (set-face-attribute 'mode-line nil :inherit 'default)
  (set-face-attribute 'mode-line-active nil :inherit 'mode-line)
  (set-face-attribute 'mode-line-inactive nil :inherit 'mode-line))

[tshu-w]

Yes, I find this issue still happen when I switch to some other app and switch back on macOS. I thought it's emacs29 bug.

[GorrillaRibs]

I haven't gotten around to submitting a bug upstream yet, but for now building with this patch is working fine

modeline.patch.gz

updated, I had the patch inline but it was way too long

[seagle0128]

The latest Emacs 29 fixed the issue. I am closing the issue.

[skyler544]

The latest Emacs 29 fixed the issue. I am closing the issue.

Could you let me know which commit fixed this? I assumed that I would get the fix if I waited a few days and rebuilt, but since this comment I've rebuilt several times and the fix has yet to appear.

[seagle0128]

@skyler544 emacs-mirror/emacs@2001ae5

[skyler544]

The last commit I built from was yesterday: emacs-mirror/emacs@cbbe235

Seems like there was either a regression or the bug is caused by something else.

[seagle0128]

It seems it's a regression issue. You can check the faces of mode-line. I don't want to change before the functionalities are stable in 29.

[Retrodynen]

@skyler544 did you find a solution? i still have this issue on da0d598190c3337c4acb2adb7435b756c655af87

[skyler544]

@skyler544 did you find a solution? i still have this issue on da0d598190c3337c4acb2adb7435b756c655af87

I got sick of frequent problems while on the development branch and now that Emacs 28 is in pre-release I've switched to it and haven't had any issues. Neither my daily config or the minimal config I posted above show this bug on Emacs 28.

[Retrodynen]

ah ok, fair enough. thanks for the reply, i'll do the same this evening

[Retrodynen]

yeah seems it's an Emacs 29-specific issue :)

[seagle0128]

So I suggest to use 28 until 29 is stable.