[Bug] Modeline isn't setup correctly after helm candidates update

[lerouxrgd]

Thank you for the bug report

• I am using the latest version of doom-modeline related packages.
• I checked FAQ.
• You may also try reproduce the issue using clean environment and minimal configurations with
  the command emacs -Q.

Bug description

When using a helm command that has dynamic candidates (helm-ag or helm-fd for instance), the doom-modeline is displayed/setup correctly at start:

But when I type some input that yields candidates, then the modeline is displayed/setup without doom-modeline:

Note that if I move (line up/down) then the modeline is displayed correctly. If there are no candidates after my input, the modeline is also displayed correctly:

Steps to reproduce

Type:

;; M-x eval-expression
(helm-do-ag (cdr (project-current)))

;; M-x eval-expression
(helm-fd-1 (cdr (project-current)))

Then type some input

Expected behavior

The modeline should be displayed with doom-modeline settings after candidates update.

OS

Linux

Emacs Version

28

Emacs Configurations

Vanilla

Error callstack

No response

Anything else

My config is as follows:

(use-package doom-modeline
  :hook (window-setup . doom-modeline-mode)
  :config
  (setq doom-modeline-icon t
        doom-modeline-major-mode-icon nil
        doom-modeline-minor-modes t
        doom-modeline-buffer-file-name-style 'relative-from-project
        doom-modeline-buffer-encoding nil)
  (add-hook 'helm-minibuffer-set-up-hook
            (lambda () (advice-add #'doom-modeline--active :override (lambda () t))))
  (add-hook 'helm-cleanup-hook
            (lambda () (advice-remove #'doom-modeline--active (lambda () t))))
)

[seagle0128]

Why do you setup these?

(add-hook 'helm-minibuffer-set-up-hook
            (lambda () (advice-add #'doom-modeline--active :override (lambda () t))))
  (add-hook 'helm-cleanup-hook
            (lambda () (advice-remove #'doom-modeline--active (lambda () t))))

[lerouxrgd]

This is as per your advice, otherwise I have the same graphic bug as #114

Note that I tried removing them, I still have the bug described in this issue

[seagle0128]

This is as per #114 (comment), otherwise I have the same graphic bug as #114

Okay. I got that. It's a workaround and I think it may be not necessary currently.

I tested with helm-rg since I am not using ag. The functionality is fine.

Please test with emacs -Q to make sure your private configurations won't impact.. I don't think helm-do-ag or helm-fd-1 is a proper step to reproduce.

[lerouxrgd]

I used to use helm-rg too, sadly it is now unmaintained and therefore I stopped using it. I tried it quickly again and indeed the issue does not happen.

However helm-ag is maintained as part of Emacs Orphanage and helm-fd is part of helm itself. Therefore they are both more up to date regarding official helm and as such helm-do-ag and helm-fd-1 are actually better steps to reproduce that helm-rg which is outdated (I suspect this is why the issue is not happening with it).

I will try to reproduce with a configuration from scratch, but honestly I don't think there is anything special in my config that interacts with doom-modeline.

[seagle0128]

Got you! I think there may be some special handles of mode-line in helm. Will check later.

[seagle0128]

After I research for a while, I realized the mode-line-format was set by helm after an async process finished. I am afraid it is not able to override the behaviors.

If you happen to know the solution, please let me know kindly. Thanks!

[lerouxrgd]

Thank you for narrowing it down.

Indeed it looks like there isn't much we can do for helm-fd therefore I opened a PR there.

As for helm-ag this can actually be fixed with:

(setq helm-ag-show-status-function nil)

Maybe this can be set in doom-modeline-segments.el at the Helm section ?

[seagle0128]

Yes. I can handle helm-ag, but nothing to do for others, liks helm-fd, helm-grep, helm-locate, etc.

[lerouxrgd]

Actually since my PR has been merged in helm, for helm-fd you can now do:

(setq helm-fd-mode-line-function nil)

[seagle0128]

My solution is (advice-add #'helm-display-mode-line :after #'doom-modeline-set-helm-modeline).

It's better if you can submit some PRs for other helm functions, to add some hooks or something like that.