-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] need update for latest jsonrpc accessor change: jsonrpc--request-continuations
#687
Comments
Thank you for the kind reminder! |
This fix results in error on Emacs 29.1:
|
Hi, should I unpin the package to use the fixed version? |
@pcompassion pls use the latest version. |
@seagle0128 thanks for the response, but i tried doing (unpin! doom-modeline) in my packages.el (unless (modulep! +light) (unless (modulep! +light) and doing doom-sync, doens't give me the latest version.. |
@pcompassion I think you should file an issue for doom emacs. |
@pcompassion maybe you need [1] https://github.com/doomemacs/doomemacs/blob/master/docs/getting_started.org#the-bindoom-utility
|
@seagle0128 @pcompassion thanks for the responses, i'll handle it |
Thank you for the bug report
doom-modeline
related packages.the command
emacs -Q
.Bug description
In emacs commit dceffddbfe7,
jsonrpc--request-continuations
is replaced withjsonrpc--continuations
inlisp/jsonrpc.el
. As of doom-modeline a312ea8,doom-modeline-segments.el
uses the old accessor function.This trivial patch fixes it for me:
but I expect the actual fix will need to cover both cases for compatibility.
Steps to reproduce
Try to use eglot with doom-modeline, using latest master emacs.
Expected behavior
Should work without error.
OS
Windows
Emacs Version
30
Emacs Configurations
No response
Error callstack
No response
Anything else
No response
The text was updated successfully, but these errors were encountered: