Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support for Flycheck-status-emoji #688

Closed
chookity-pokk opened this issue Jan 11, 2024 · 4 comments
Closed

[Feature Request] Support for Flycheck-status-emoji #688

chookity-pokk opened this issue Jan 11, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@chookity-pokk
Copy link

Is your feature request related to a problem? Please describe.
There is a package called flycheck-status-emoji that unfortunately can't be used with Doom modeline. When trying to use it the flycheck icon doesn't change but is visible when turning off doom modeline.

Describe the solution you'd like
The ability to either have some compatibility with flycheck status emoji. Maybe the option to choose between the built in flycheck and that one.

Describe alternatives you've considered
I tried looking into checking the flycheck icon but that doesn't really have the same ability as the described package.

@chookity-pokk chookity-pokk added the enhancement New feature or request label Jan 11, 2024
@seagle0128
Copy link
Owner

seagle0128 commented Jan 12, 2024

Enable doom-modeline-minor-modes (DON'T diminish flycheck-mode), or (add-to-list 'global-mode-string flycheck-mode-line).

@chookity-pokk
Copy link
Author

chookity-pokk commented Jan 12, 2024

(add-to-list 'global-mode-string flycheck-mode-line)

This seems to work on the dashboard but once entering a python file it gets rid of that as well as my perspective. My global mode string is

((:eval
  (flycheck-status-emoji-mode-line-text))
 ""
 (:eval
  (persp-mode-line)))

It seems like even if I remove the flycheck stuff from there I miss my perspective anyway which I don't think has usually been the case?

image image

Here is my whole config,

(use-package doom-modeline
  :ensure t
  :init (slot/vc-install :fetcher "github" :repo "seagle0128/doom-modeline"))

(setq doom-modeline-total-line-number t)
(setq doom-modeline-indent-info t)
(setq doom-modeline-persp-name t)
(add-to-list 'global-mode-string flycheck-mode-line)
(doom-modeline-mode 1)

@chookity-pokk
Copy link
Author

Okay, so I didn't change anything but it works now. I restarted Emacs several times and it didn't work any of those times but this time it seems to have worked. I am going to try and reproduce this and I'll update the issue with what worked and then I'll close it. Thank you for the help!

image

@chookity-pokk
Copy link
Author

Yep, I can't reproduce it not working anymore. It wasn't working, I restarting Emacs probably 10+ times, still didn't work. I tried setting my own modeline value to make sure that was working, it did. I then enabled doom modeline again and it started working. Just a day in the life.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants