Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error using with latest eglot / jsonrpc packages #689

Closed
2 of 3 tasks
bradhowes opened this issue Jan 13, 2024 · 4 comments
Closed
2 of 3 tasks

Error using with latest eglot / jsonrpc packages #689

bradhowes opened this issue Jan 13, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@bradhowes
Copy link

Thank you for the bug report

  • I am using the latest version of doom-modeline related packages.
  • I checked FAQ.
  • You may also try reproduce the issue using clean environment and minimal configurations with
    the command emacs -Q.

Bug description

I upgraded my packages and this brought down eglot v1.16 (built-in is 1.12.29). This installed an updated jsonrpc package v1.0.23. When starting a mode that uses eglot there now appears the following error:

Error running timer: (void-function jsonrpc--request-continuations)

This is due to the fact that that function no longer exists in the jsonrpc package.

I removed the eglot upgrade for now until doom-modeline is updated.

Steps to reproduce

  • Upgrade eglot to v1.16
  • Restart Emacs
  • Edit source file that uses eglot or start it manually with M-x eglot

Expected behavior

No error.

OS

MacOS

Emacs Version

29

Emacs Configurations

Custom

Error callstack

Debugger entered--Lisp error: (void-function jsonrpc--request-continuations)
  jsonrpc--request-continuations(#<eglot-lsp-server eglot-lsp-server-52c05d10>)
  doom-modeline-update-eglot()
  run-hooks(eglot-managed-mode-hook)
  eglot--maybe-activate-editing-mode()
  run-hooks(after-change-major-mode-hook)
  run-mode-hooks(python-mode-hook)
  python-mode()


### Anything else

Fix for now is to remove the `eglot` and `jsonrpc` upgrades for now until `doom-modeline` is updated.
@bradhowes bradhowes added the bug Something isn't working label Jan 13, 2024
@bradhowes
Copy link
Author

bradhowes commented Jan 13, 2024

Appears that jsonrpc-continuation-count would be the likely candidate to use instead. It works for me but the number that it shows make no sense -- string of repeated '100'...

EDIT: the count works OK. The string of repeated '100'... is due to something else I think (icon?) not related to this.

@seagle0128
Copy link
Owner

seagle0128 commented Jan 14, 2024

Please make sure you are using the latest version of doom-modeline.

See https://github.com/seagle0128/doom-modeline/blob/master/doom-modeline-segments.el#L2072-L2076 .

@bradhowes
Copy link
Author

Thanks for the response. I do not see anything more than 4.0.1 and that is what I've been using.

@seagle0128
Copy link
Owner

seagle0128 commented Jan 22, 2024

Are you using the melpa-stable version? I've pushed a new tag: v4.1.0. Please try later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants