Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding local cluster to make k8s deployment work out of the box #1203

Closed
aiwantaozi opened this issue Aug 25, 2023 · 6 comments
Closed
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@aiwantaozi
Copy link
Contributor

Is your enhancement related to a problem? Please describe.

Describe the solution you'd like
Add a flag to support adding local k3s to the default project, which makes it easier to try out.

@aiwantaozi aiwantaozi added the enhancement New feature or request label Aug 25, 2023
@gitlawr gitlawr added this to the v0.3.1 milestone Aug 28, 2023
@thxCode thxCode self-assigned this Aug 29, 2023
@thxCode thxCode added wontfix This will not be worked on and removed enhancement New feature or request labels Aug 30, 2023
@thxCode thxCode removed this from the v0.3.1 milestone Aug 30, 2023
@thxCode
Copy link
Member

thxCode commented Aug 30, 2023

After a discussion with the internal team, we are not going to support this at present. The point of view is as follows,

  1. Walrus is a platform to shorten the path of application deployment, the Kubernetes cluster is not the only target that Walrus focuses on. Walrus leverages a deployer, at present, a Terraform CLI, to finish the application deployment. Running a deployment is typically an elastic, asynchronous, and inherently stateless process, so a Kubernetes cluster matches this perfectly. In short, how to finish a deployment is what Walrus cares about, but where to deploy is what users care about.
  2. Walrus provides an embedding Kubernetes cluster, it's like when you buy a cell phone you always have a battery. If users really want to deploy something to the embedding Kubernetes cluster, or the Kubernetes cluster specified by --kube-config, please try add a Kubernetes Connector.
  3. For a quick start, there are many ways to have a Kubernetes cluster now, Kind, K3d, Docker Desktop, Rancher Desktop and cloud Kuberentes services. The only concern for the user is to ensure that the target cluster is reachable from the Walrus's "battery" cluster.

@gitlawr gitlawr closed this as completed Aug 30, 2023
@orangedeng
Copy link

Thanks for taking this seriously. My point is that the user will get distracted very easily when deploying a new k8s. The public cloud is not the first choice in many case(mostly because of the cost). And like you said, people can deploy their own cluster by them selves, but also they will lost focus when finding out how to do it.

In quick start docs, you can add k8s cluster install link to guide user to do so.
Or as the suggestion above, you already have the embed k3s cluster, why not expose it to let people get to the core of Walrus?

@rainfd
Copy link
Contributor

rainfd commented Sep 1, 2023

The current version is not yet roubust enough to allow users to arbitrarily modify walrus internal k8s resources. And it is not certain that future versions will still use k8s as the basis for our orchestration. @orangedeng

@orangedeng
Copy link

orangedeng commented Sep 3, 2023

Yeah, i get that. I also don't think the embed k3s is a good idea to run terraform job. So adding the k3d/k3s quick start link to the docs should be enough.

@gitlawr
Copy link
Contributor

gitlawr commented Dec 25, 2023

We've revisited the issue and plan to support it in the next release.

@gitlawr gitlawr reopened this Dec 25, 2023
@gitlawr gitlawr changed the title Support add local k3s to make deploy to k8s out of the box Support add local k8s to make deploy to k8s out of the box Dec 25, 2023
@gitlawr gitlawr changed the title Support add local k8s to make deploy to k8s out of the box Support adding local cluster to make k8s deployment work out of the box Dec 25, 2023
@gitlawr gitlawr removed the wontfix This will not be worked on label Dec 25, 2023
@gitlawr gitlawr added this to the v0.5.0 milestone Dec 25, 2023
@gitlawr gitlawr added the enhancement New feature or request label Dec 25, 2023
@gitlawr gitlawr self-assigned this Dec 29, 2023
@Finenyaco
Copy link

Environment

  • Walrus version: main c7df618
  • UI version: dev-04f141b

Test Result:

Docker:

  • Embedded Kubernetes cluster: pass
  • Using an external Kubernetes cluster (--kubeconfig): pass
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants