Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the option not to download GPL data #6

Closed
renozao opened this issue Feb 4, 2014 · 2 comments
Closed

Give the option not to download GPL data #6

renozao opened this issue Feb 4, 2014 · 2 comments
Assignees

Comments

@renozao
Copy link

renozao commented Feb 4, 2014

Would it be possible to add an argument to getGEO, e.g., GPLdata = TRUE, or define a special meaning for an NA value in AnnotGPL, that indicates if GPL feature data should be downloaded at all?

Example:

> eset <- getGEO('GSE12345')
> head(fData(eset)[, 1:5])
                 ID GB_ACC SPOT_ID Species Scientific Name Annotation Date
1007_s_at 1007_s_at U48705    <NA>            Homo sapiens     Jun 9, 2011
1053_at     1053_at M87338    <NA>            Homo sapiens     Jun 9, 2011
117_at       117_at X51757    <NA>            Homo sapiens     Jun 9, 2011
121_at       121_at X69699    <NA>            Homo sapiens     Jun 9, 2011
1255_g_at 1255_g_at L36861    <NA>            Homo sapiens     Jun 9, 2011
1294_at     1294_at L13852    <NA>            Homo sapiens     Jun 9, 2011
> 
> # while no feature data is fetched with:
> eset <- getGEO('GSE12345', GPLdata = FALSE)
> # or
> # eset <- getGEO('GSE12345', AnnotGPL = NA)
> featureData(eset)
An object of class 'AnnotatedDataFrame': none
> fData(eset)
data frame with 0 columns and 54675 rows

Note that one needs to be careful when setting an empty feature data AnnotatedDataFrame object: rownames must still correspond to featureNames, otherwise the object does not pass validation:

> featureData(eset) <- AnnotatedDataFrame(data.frame(row.names = featureNames(eset)))
> validObject(eset)
[1] TRUE
> featureData(eset) <- AnnotatedDataFrame()
> validObject(eset)
Error in validObject(eset) : 
  invalid class “ExpressionMix” object: 1: feature numbers differ between assayData and featureData
invalid class “ExpressionMix” object: 2: featureNames differ between assayData and featureData

Thanks!

seandavi added a commit that referenced this issue Feb 9, 2014
This was requested as a feature in issue #6.
@seandavi seandavi self-assigned this Feb 9, 2014
seandavi added a commit that referenced this issue Feb 9, 2014
This should complete the fixes for issue #6, but still need to add
some testing, so will keep open for now.
seandavi added a commit that referenced this issue Feb 9, 2014
This should complete the fixes for issue #6.
ghost pushed a commit that referenced this issue Feb 9, 2014
Consists of 2 commit(s).

Commit information:

    Commit id: 96829c2
    Commit message:
    Added unit tests for using getGPL=FALSE in getGEO

    This should complete the fixes for issue #6.
    Committed by Sean Davis <seandavi at gmail.com>
    Commit date: 2014-02-09T12:15:05-08:00

    Commit id: e85c87c
    Commit message:
    Merge branch 'master' of github.com:seandavi/GEOquery
    Committed by Sean Davis <seandavi at gmail.com>
    Commit date: 2014-02-09T12:16:29-08:00

From: Bioconductor Git-SVN Bridge <bioc-sync@bioconductor.org>

git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/GEOquery@86258 bc3139a8-67e5-0310-9ffc-ced21a209358
@seandavi
Copy link
Owner

seandavi commented Feb 9, 2014

Hi, Renaud.

I think this should allow the functionality that you want. You can either checkout from here or install from the devel branch on bioc in a day or so after the build system has done its thing. I am closing, but feel free to reopen or simply put in a new issue if this doesn't meet your needs.

@seandavi seandavi closed this as completed Feb 9, 2014
@renozao
Copy link
Author

renozao commented Feb 10, 2014

Thanks!

seandavi pushed a commit that referenced this issue May 8, 2016
Consists of 2 commit(s).

Commit information:

    Commit id: 96829c2
    Commit message:
    Added unit tests for using getGPL=FALSE in getGEO

    This should complete the fixes for issue #6.
    Committed by Sean Davis <seandavi at gmail.com>
    Commit date: 2014-02-09T12:15:05-08:00

    Commit id: e85c87c
    Commit message:
    Merge branch 'master' of github.com:seandavi/GEOquery
    Committed by Sean Davis <seandavi at gmail.com>
    Commit date: 2014-02-09T12:16:29-08:00

From: Bioconductor Git-SVN Bridge <bioc-sync@bioconductor.org>

git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/GEOquery@86258 bc3139a8-67e5-0310-9ffc-ced21a209358
seandavi added a commit that referenced this issue Sep 23, 2017
Consists of 2 commit(s).

Commit information:

    Commit id: 96829c2
    Commit message:
    Added unit tests for using getGPL=FALSE in getGEO

    This should complete the fixes for issue #6.
    Committed by Sean Davis <seandavi at gmail.com>
    Commit date: 2014-02-09T12:15:05-08:00

    Commit id: e85c87c
    Commit message:
    Merge branch 'master' of github.com:seandavi/GEOquery
    Committed by Sean Davis <seandavi at gmail.com>
    Commit date: 2014-02-09T12:16:29-08:00

From: Bioconductor Git-SVN Bridge <bioc-sync@bioconductor.org>

git-svn-id: file:///home/git/hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/GEOquery@86258 bc3139a8-67e5-0310-9ffc-ced21a209358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants