Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Improvement: BoatEdit>EditPolar>Polar #173

Closed
rgleason opened this issue Mar 18, 2018 · 6 comments
Closed

UI Improvement: BoatEdit>EditPolar>Polar #173

rgleason opened this issue Mar 18, 2018 · 6 comments

Comments

@rgleason
Copy link
Contributor

rgleason commented Mar 18, 2018

We cannot see the entire dropdown. Most users have NO clue what this is for!!!

What is the conceptual difference between these graphs? Sean please Explain, this will find its way into the wiki.
Does the selection affect Compute Calculations?

boatedit-editpolar-polar-truewindangle
"True Wind Direction - True Wind Speed" - current text
TWA/TWS
Radials=TWA, Circular=Boat Speed, Spiraling=Optimal Boat Speed at various TWS

boatedit-editpolar-polar-apparentwindangle
"Apparent Wind Direction - Apparent Wind Speed" - current text
AWA/AWS
Radials=AWA, Circular=Boat Speed, Spiraling=Optimal Boat Speed at various AWS

boatedit-editpolart-polar-truewindspeed
"True Wind Direction / Apparent Wind Speed" -current text
TWA/AWS
Radials=TWA, Circular=Boat Speed, Spiraling=Optimal Boat Speed at various AWS

boatedit-editpolar-polar-apparentwindspeed
"Apparent Wind Direction / True Wind Speed" -current text
AWA/TWS
Radials=AWA, Circular=Boat Speed, Spiraling=Optimal Boat Speed at various TWS

@seandepagnier
Copy link
Owner

The selection makes no difference to calculation and is for visualization only.

@rgleason
Copy link
Contributor Author

rgleason commented Mar 24, 2018

Wholybee wrote:

This bothered me immensely, and was an easy fix. Just comment the following line in
WeatherRoutingUI.cpp

1786: // m_cPlotVariable->SetMaxSize( wxSize( 120,-1 ) );
Not sure how it affects other OS's, but it displays fine in Windows after that.

Rick wrote:
Doing this breaks the fpb file I think, but it is a good test. The change needs to be done by someone using the most current FormBuilderWx. Sean has not accepted these kinds of PR changes from me in the past so I am not going to try it. After the change is made in FormbuilderWx and saved. Then the other files get generated freshly when you compile.

@rgleason
Copy link
Contributor Author

rgleason commented Mar 24, 2018

  1. I think the shorter designation is better
  • TWA/TWS
  • AWA/AWS
  • TWA/AWS
  • AWA/TWS
  1. I believe these are Angles not Directions.
  2. Users can refer to Terminology Page here and if they are sailors should know this anyway.
  3. How to make the point the dropdown selection does not affect calculations? That these are just different graphical representations of the same polar file data? (note in the manual?)

@rgleason
Copy link
Contributor Author

rgleason commented Mar 24, 2018

screenshot 295

Commenting the line out works, but it squeezes out the Checkbox for a "Full Plot"
The solution is really to use the acronyms as above for text and set the box width appropriately so the checkbox "Full Plot" also shows.

screenshot 260

@rgleason
Copy link
Contributor Author

I think this would be changed here, but I might be wrong, so I am not going to do it. Perhaps someone else can?
EditpolarDialog.cpp
Line 45
// m_gPolar->Connect( wxEVT_GRID_CELL_CHANGED, wxGridEventHandler( EditPolarDialogBase::OnPolarGridChanged ), NULL, this );

m_lMeasurements->InsertColumn(spTRUE_WIND_SPEED, _("True Wind Speed"));
m_lMeasurements->InsertColumn(spTRUE_WIND_DIRECTION, _("True Wind Direction"));
m_lMeasurements->InsertColumn(spAPPARENT_WIND_SPEED, _("Apparent Wind Speed"));
m_lMeasurements->InsertColumn(spAPPARENT_WIND_DIRECTION, _("Apparent Wind Direction"));
m_lMeasurements->InsertColumn(spBOAT_SPEED, _("Boat Speed"));
m_lMeasurements->InsertColumn(spETA, _("Sailboat Transform ETA"));

}

@rgleason
Copy link
Contributor Author

rgleason commented Jun 1, 2018

The plugin formbuilder action has been changed so we now can see the full titles of the dropdown.
Sean notes that
"The selection makes no difference to calculation and is for visualization only."
I am also going to make some notes about this in the wiki.
At this point it is time to close this.

@rgleason rgleason closed this as completed Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants