Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support responsive line-height #18

Closed
perrin4869 opened this issue Jun 10, 2016 · 4 comments
Closed

Support responsive line-height #18

perrin4869 opened this issue Jun 10, 2016 · 4 comments

Comments

@perrin4869
Copy link
Contributor

Could be really useful, might send a pull request tomorrow

@madeleineostoja
Copy link
Owner

There's a discussion going at madeleineostoja/rucksack#31 about this. Not sure if it falls within responsive-font-sizes purview, especially since line-height can already be a unitless value, and it would have to parse line-height values separately. Might be better suited to an accompanying responsive-line-height plugin.

@perrin4869
Copy link
Contributor Author

Well, this repo is called responsive-type, and line-height is part of type, so I think it belongs here conceptually. Also, a lot of the implementation details are similar, so practically speaking sharing the same codebase will make things cleaner.

I'll work on the pull request in a little bit, maybe also throw in a bit of documentation for the supported unit combinations as well. Thanks!

@madeleineostoja
Copy link
Owner

Yep that's fair. Definitely open to a pull request.

@perrin4869
Copy link
Contributor Author

Cool, you can close this now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants