Add support for responsive line height + bonuses #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param {object} rule CSS rule to parse | ||
| */ | ||
| var fetchParams = function(rule, declName){ | ||
| var params = R.clone(defaultParams[declName]); |
There was a problem hiding this comment.
Is this the only place Ramda is used? Pretty bulky dep just for a clone func, especially when we don't actually need a deep clone here.
There was a problem hiding this comment.
hm... maybe replace with this then: https://github.com/pvorb/node-clone?
|
Made a couple of line comments, just small things. Otherwise looks good! |
|
made some changes according to your comments, for your consideration :) |
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for responsive
line-height, and refactored the code a bit to be more functional. Also, since it was so easy to do, I added responsiveletter-spacing, just for the giggles :)