Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

waf does not rebuild modified files. #80

Open
dulimarta opened this issue Jan 3, 2015 · 2 comments
Open

waf does not rebuild modified files. #80

dulimarta opened this issue Jan 3, 2015 · 2 comments

Comments

@dulimarta
Copy link

Typing waf html does not automatically rebuild modified files.

Steps to reproduce this bug:

  • Run waf ohtml to build generate and browse the HTML documents
  • Add a line of text into manual/shells.rst
  • Run waf html to rebuild the documents
  • Refresh the browser (the changes made in shells.rst do not appear)
@seanfisk
Copy link
Owner

seanfisk commented Jan 4, 2015

This is a pretty common workflow, so I'd think we would have noticed it pretty soon after it cropped up. Anyway, I wasn't able to reproduce the bug from some presumptive tests.

Could you try running this for me?

bash -c './waf distclean configure -d ohtml && cp build/manual/html/shells.html{,.old} && echo -e "\nshould be in diff" >> manual/shells.rst && ./waf html && diff -u build/manual/html/shells.html{.old,}'

The output of the diff command (at the end) should be:

--- build/manual/html/shells.html.old   2015-01-03 23:21:41.000000000 -0500
+++ build/manual/html/shells.html   2015-01-03 23:21:43.000000000 -0500
@@ -220,6 +220,7 @@
 <div class="section" id="kornshell">
 <h2>Kornshell<a class="headerlink" href="#kornshell" title="Permalink to this headline">¶</a></h2>
 <p><a class="reference external" href="http://www.kornshell.org">Kornshell</a> is a shell developed at AT&amp;T Bell Laboratories. It has features of both the Bash and Korn shells, as well as additional features.</p>
+<p>should be in diff</p>
 </div>
 </div>

@@ -246,7 +247,7 @@
       &copy; Copyright 2015 Sean Fisk and Ira Woodring<br />
       <a rel="license" href="http://creativecommons.org/licenses/by-nc-sa/4.0/"><img alt="Creative Commons License" style="border-width:0" src="https://i.creativecommons.org/l/by-nc-sa/4.0/80x15.png" /></a>&nbsp;&nbsp;All text licensed under the <a href="http://creativecommons.org/licenses/by-nc-sa/4.0/">Creative Commons BY-NC-SA 4.0 License</a>.<br />
       <a href="http://www.apache.org/licenses/LICENSE-2.0"><img src="_static/apache-feather.png" height="15"></a>&nbsp;&nbsp;All code licensed under the <a href="http://www.apache.org/licenses/LICENSE-2.0">Apache 2.0 License</a> unless otherwise stated.<br />
-      Revision <a href="https://github.com/seanfisk/mastering-eos/commit/2960335">2960335</a> built 2015-01-03 23:21:35 EST.<br />
+      Revision <a href="https://github.com/seanfisk/mastering-eos/commit/2960335">2960335</a> built 2015-01-03 23:21:43 EST.<br />
     </p>
   </div>

Obviously the build date is going to differ, but we are also looking for the should be in diff part. Let me know what the result is.

@seanfisk
Copy link
Owner

seanfisk commented May 1, 2015

@dulimarta I haven't heard back on this. Are you still having this problem, or can I close this issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants