feat(signer): always return string signatures

starknet-io · Mar 3, 2022 · 0e9dd6c · 0e9dd6c
1 parent fa29b6a
commit 0e9dd6c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/types/lib.ts b/src/types/lib.ts
@@ -3,7 +3,7 @@ import type { ec as EC } from 'elliptic';
 import type { BigNumberish } from '../utils/number';
 
 export type KeyPair = EC.KeyPair;
-export type Signature = BigNumberish[];
+export type Signature = string[];
 export type RawCalldata = BigNumberish[];
 
 export type DeployContractPayload = {

diff --git a/src/utils/ellipticCurve.ts b/src/utils/ellipticCurve.ts
@@ -80,7 +80,7 @@ export function sign(keyPair: KeyPair, msgHash: string): Signature {
   assertInRange(r, ONE, toBN(addHexPrefix(MAX_ECDSA_VAL)), 'r');
   assertInRange(s, ONE, toBN(addHexPrefix(EC_ORDER)), 's');
   assertInRange(w, ONE, toBN(addHexPrefix(MAX_ECDSA_VAL)), 'w');
-  return [r, s];
+  return [r.toString(), s.toString()];
 }
 
 function chunkArray(arr: any[], n: number): any[][] {