Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate library? #119

Closed
SUPERCILEX opened this issue Feb 24, 2022 · 6 comments
Closed

Deprecate library? #119

SUPERCILEX opened this issue Feb 24, 2022 · 6 comments

Comments

@SUPERCILEX
Copy link

Or at least prominently point people towards std? https://doc.rust-lang.org/stable/std/thread/fn.available_parallelism.html

@seanmonstar
Copy link
Owner

Take a look at the limitations section on that function. This crate does check processor affinity, and cgroups, and doing so has an important impact on servers running in containers.

@SUPERCILEX
Copy link
Author

Interesting, looks like there's a PR to fix that: rust-lang/rust#92697. In the meantime, perhaps it's worth pointing out the differences?

@pro465
Copy link

pro465 commented May 23, 2022

update: the mentioned PR is now merged

@link2xt
Copy link

link2xt commented Jun 2, 2022

Here async-global-executor crate switched to the standard API: async-rs/async-global-executor#6

Here rayon crate is considering dropping the library: rayon-rs/rayon#937

@notgull
Copy link

notgull commented Jun 2, 2022

Either way, I feel like the important thing is that this crate is available on earlier versions of Rust, which is important to crates who don't want to bump their MSRV.

@seanmonstar
Copy link
Owner

Yea, probably not going to do this just yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants