New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to hyper v1 #1088
Comments
@seanmonstar I have an in-progress PR #1090 . There are a few issues though. One big one is figuring out what the Response type should be. e.g. should it be a Response? (the new name for the old Body struct). or should it be some type of BxBody? The issue I had with BxBodyempty was even with that I couldn't coerce a http_body_util::Empty has a different error class (Infallible) over the error type for the Incoming strict, thus using http_body_util::Empty in place of Incoming::empty() does not work with that. Then there is the whole gutting of the server and stream stuff out of Hyper that will need to be rewritten/replaced. |
@urkle @seanmonstar |
I make occasional progress as time allows, though many my users and client direct my attention elsewhere. |
@seanmonstar if you can find some time to look at my PR and provide suggestions/feedback on the items I posted there that would be helpful so I can move forward on that PR |
Now that hyper 1.0 is out we should upgrade warp to use the new version of hyper.
I have attempted locally to perform this update and there are a number of items that need to be reworked due to the removal of many high-level items from hyper.
How do you want to approach a PR upgrading Hyper? e.g. I can push up what I have so far and we can work through the compile errors.
The text was updated successfully, but these errors were encountered: