Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to hyper v1 #1088

Open
urkle opened this issue Jan 20, 2024 · 4 comments
Open

Upgrade to hyper v1 #1088

urkle opened this issue Jan 20, 2024 · 4 comments
Labels
feature New feature or request

Comments

@urkle
Copy link
Contributor

urkle commented Jan 20, 2024

Now that hyper 1.0 is out we should upgrade warp to use the new version of hyper.

I have attempted locally to perform this update and there are a number of items that need to be reworked due to the removal of many high-level items from hyper.

How do you want to approach a PR upgrading Hyper? e.g. I can push up what I have so far and we can work through the compile errors.

@urkle urkle added the feature New feature or request label Jan 20, 2024
@urkle
Copy link
Contributor Author

urkle commented Jan 31, 2024

@seanmonstar I have an in-progress PR #1090 .

There are a few issues though.

One big one is figuring out what the Response type should be. e.g. should it be a Response? (the new name for the old Body struct). or should it be some type of BxBody?

The issue I had with BxBodyempty was even with that I couldn't coerce a http_body_util::Empty has a different error class (Infallible) over the error type for the Incoming strict, thus using http_body_util::Empty in place of Incoming::empty() does not work with that.

Then there is the whole gutting of the server and stream stuff out of Hyper that will need to be rewritten/replaced.

@kimhanbeom
Copy link

@urkle @seanmonstar
Does warp currently have any plans for hyper 1.x?

@seanmonstar
Copy link
Owner

I make occasional progress as time allows, though many my users and client direct my attention elsewhere.

@urkle
Copy link
Contributor Author

urkle commented Apr 25, 2024

@seanmonstar if you can find some time to look at my PR and provide suggestions/feedback on the items I posted there that would be helpful so I can move forward on that PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants