Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs touch-up for Rejections #126

Closed
seanmonstar opened this issue Oct 29, 2018 · 5 comments
Closed

Docs touch-up for Rejections #126

seanmonstar opened this issue Oct 29, 2018 · 5 comments
Labels
easy Good for newcomers

Comments

@seanmonstar
Copy link
Owner

With the changes to the Rejection system (#115), the docs could use some improvements.

  • The docs for warp::reject::custom should link to Filter::recover.
  • The docs for warp::Rejection should link to the warp::reject module documentation.
  • The warp::reject module docs should expand on how to recover from rejections.
@seanmonstar seanmonstar added the easy Good for newcomers label Oct 29, 2018
@boxdot
Copy link
Contributor

boxdot commented Jan 19, 2020

Looks like this was already done in the commit b262f93.

@jxs
Copy link
Collaborator

jxs commented Jan 19, 2020

The warp::reject module docs should expand on how to recover from rejections.

only this one is missing

@calvinbrown085
Copy link
Contributor

I can grab

The warp::reject module docs should expand on how to recover from rejections.

@calvinbrown085
Copy link
Contributor

Is there a specific example on what kind of rejection you'd want to recover from?

@jxs
Copy link
Collaborator

jxs commented Jul 1, 2021

fixed with #876

@jxs jxs closed this as completed Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants