Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive Request - Series Type Parameter not working #2

Closed
cmdigital opened this issue Oct 31, 2020 · 2 comments
Closed

Archive Request - Series Type Parameter not working #2

cmdigital opened this issue Oct 31, 2020 · 2 comments

Comments

@cmdigital
Copy link

cmdigital commented Oct 31, 2020

SeriesType Parameter needs to be named in Query string in order to work. (Currently being ignored)

Proposed fix:
InverterArchiveDataService.cs
Line 51

return $"?Scope={scope}&StartDate={startDate.ToString("d.M.yyyy")}&EndDate={endDate.ToString("d.M.yyyy")}&HumanReadable={humanReadable.ToString()}&SeriesType={seriesType.ToString()}{deviceClassParam}" + $"&{channelParam}";

    }
@SeanoNET
Copy link
Owner

SeanoNET commented Nov 3, 2020

Hi @cmdigital

Thanks for pointing this out, I will take a look at this in the next few days, I am also happy to review a PR in the meantime.

SeanoNET added a commit that referenced this issue Nov 4, 2020
@SeanoNET
Copy link
Owner

SeanoNET commented Nov 4, 2020

Hi @cmdigital - solved in 0.4.0

Thanks for contributing!

@SeanoNET SeanoNET closed this as completed Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants