Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two filters do not work together #91

Open
Yashwin12 opened this issue Feb 3, 2021 · 4 comments
Open

Two filters do not work together #91

Yashwin12 opened this issue Feb 3, 2021 · 4 comments

Comments

@Yashwin12
Copy link

Following steps to re-create this issue:

  1. Filter problems with any difficulty. (In the screenshot "easy" is selected)
  2. After this, filter out with any company. (Over here "Capital One" is selected)

In the screenshot, one can see it filters out with Capital One and clearly disregard the "easy" difficulty filter. I think UI should either incorporate "smart filtering" - results considering both the filters OR reset the previously selected filter from the screen.

Screen Shot 2021-02-02 at 7 38 23 PM

@seanprashad
Copy link
Owner

Hey @Yashwin12 ✌🏽 Thanks a bunch for pointing this bug out - I just tried reproducing it using the STR you listed but it looks like filtering is working as intended:

filtering-combined.mp4

Are you able to reproduce it in Incognito mode, or just the regular website? We can try to narrow down what's busted from there

@Yashwin12
Copy link
Author

Yashwin12 commented Feb 5, 2021

Hi @seanprashad, thank you for replying back. Actually, I found why it was behaving like this; I accidentally hit the "previous" button in the browser. Please consider below STR and gif to reproduce the filter issue.

  1. Select company filter. ( Over here "Capital One" is selected )
  2. Navigate to the "previous" page in the browser.
  3. Navigate back to the Leetcode Patterns page. You can still see the filter value is present, but the values are not shown according to its filter. (I think it disregards the filter value and shows all the results).

leetCodePatterns

@seanprashad
Copy link
Owner

seanprashad commented Feb 5, 2021

Amazing stuff! I am also able to confirm the bug based on your updated STR listed.

The current behaviour doesn't save your settings (ie. Which difficulty, companies, and patterns you have filtered by, if any).

Over in #87, it was requested that these settings be saved like how the checkboxes are via Local Storage. As of right now, I think this is a UI bug which will hopefully be solved when #87 lands!

@Yashwin12
Copy link
Author

Great! I think saving filter selection in local storage is a good idea, but as a user on the page refresh, it makes more sense (at least over here) to reset filters. Just my two cents!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants