Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin compatibility issues with Python 3.7 #292

Closed
hrpzcf opened this issue Mar 21, 2023 · 4 comments · Fixed by #298 or #314
Closed

Plugin compatibility issues with Python 3.7 #292

hrpzcf opened this issue Mar 21, 2023 · 4 comments · Fixed by #298 or #314
Assignees
Labels
enhancement New feature or request

Comments

@hrpzcf
Copy link

hrpzcf commented Mar 21, 2023

2023-03-21_172302
2023-03-21_164359

两个截图中的问题是关于 := 运算符和 typing.Literal 的,据我所知这两个都是 Python 3.8+ 可用。
请问作者是否有意修复这些问题以增加对 Python 3.7 的支持?

@seanwu1105 seanwu1105 added the enhancement New feature or request label Mar 21, 2023
@seanwu1105
Copy link
Owner

Thanks for the report. I will remove the use of these language features in the next release.

@seanwu1105
Copy link
Owner

Note that, according to the official docs, Python 3.7 will end its life this June. Thus, we will drop the support at that time and use all language features compatible to 3.8+.

@ross-g
Copy link

ross-g commented Sep 19, 2023

Could I request this be reconsidered @seanwu1105 ?

While Python 3.7 is now end of life, many applications with embedded Python are still on 3.7. So far as I can see the only incompatibility is the use of the "walrus" operator in scripts/utils/__init__.py which seems trivial enough that 3.7 support could be maintained without development effort.

@seanwu1105
Copy link
Owner

Hi @ross-g, I see your point. I will add back 3.7 support then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants