Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail silently if loaded before/without jQuery #27

Closed
searls opened this issue Jan 14, 2014 · 3 comments
Closed

Don't fail silently if loaded before/without jQuery #27

searls opened this issue Jan 14, 2014 · 3 comments

Comments

@searls
Copy link
Owner

searls commented Jan 14, 2014

It's pretty confusing when affix() is missing just because it was loaded before jQuery.

@hayesr
Copy link

hayesr commented Jan 26, 2014

Thanks for pointing this out, I've been banging my head against the wall. BTW, this is exacerbated by the caching thing you already know about. ( testdouble/jasmine-rails#100 )

For my own needs I've worked around it by manually requiring a spec_helper file with jQuery and jasmine-fixtures in it.

@searls
Copy link
Owner Author

searls commented Feb 1, 2014

Agree. I'm not sure what approach I prefer? I could just wrap the whole thing in a defer (setTimeout 0) so that load order doesn't matter for tools that insist on loading specHelpers BEFORE any application code.

But that's nonstandard and baffling, so perhaps just throwing an Error is best? I bet @davemo will have an opinion on this.

@searls searls closed this as completed in d29a642 Feb 15, 2014
@searls
Copy link
Owner Author

searls commented Feb 15, 2014

Landed in 1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants