Skip to content
This repository has been archived by the owner on Jan 10, 2024. It is now read-only.

jasmine-rails breaks when jasmine-jquery updates to v2 #106

Closed
shterrett opened this issue Feb 11, 2014 · 8 comments
Closed

jasmine-rails breaks when jasmine-jquery updates to v2 #106

shterrett opened this issue Feb 11, 2014 · 8 comments

Comments

@shterrett
Copy link

When jasmine-jquery updates to >= v2, jasmine-rails breaks. This is because jasmine-rails holds jasmine-core at version ~> 1.3, and jasmine-jquery >= 2 requires jasmine-core >= 2.

Related issue on jasmine-jquery

@searls
Copy link
Member

searls commented Feb 11, 2014

Yup, jasmine-rails doesn't support jasmine 2.x, so you'll want to lock to an earlier version of jasmine-jquery to continue using it.

On Tue, Feb 11, 2014 at 1:52 PM, Stuart Terrett notifications@github.com
wrote:

When jasmine-jquery updates to >= v2, jasmine-rails breaks. This is because jasmine-rails holds jasmine-core at version ~> 1.3, and jasmine-jquery >= 2 requires jasmine-core >= 2.

Related issue on jasmine-jquery

Reply to this email directly or view it on GitHub:
#106

@jeromedalbert
Copy link

I have tried several old versions of jasmine-jquery, to no avail. Have you guys found a working version?

Meanwhile I have falled back to the jasminerice gem, but this is far from ideal since it is not maintained any more.

@brendonrapp
Copy link

Is Jasmine 2.x support something that is coming?

@searls
Copy link
Member

searls commented Feb 19, 2014

It's eighth or ninth down my personal todo list. I'd welcome a PR that made it configurable between 1.3 and 2.x, though!

On Wed, Feb 19, 2014 at 12:06 AM, Brendon Rapp notifications@github.com
wrote:

Is Jasmine 2.x support something that is coming?

Reply to this email directly or view it on GitHub:
#106 (comment)

@searls
Copy link
Member

searls commented Feb 20, 2014

Tracking this issue from #93 going forward

@searls searls closed this as completed Feb 20, 2014
@eyaleizenberg
Copy link

Took me a long time to find this... Using an old jasmine-jquery worked.

@eyaleizenberg
Copy link

Any news on when you will upgrade to jasmine 2?

@searls
Copy link
Member

searls commented May 27, 2014

Yeah, so I agree with everyone in this thread that the current behavior is obnoxious. Ideas on how jasmine-rails should behave?

Ideas? jasmine-rails could

  • print an install message warning users which jasmine they just got saddled with (which will probably just annoy people until they learn to ignore it)
  • we could introduce a meta-gem over the two jasmine-core gems, which i really would rather not maintain
  • we could force users to specify the version they want in their jasmine.yml file and then blow up when we discover the wrong gem? (but i don't think that'd be any more discoverable)
  • we could explicitly discover plugins we know are incompatible (like jasmine-jquery and jasmine-stealth) and print a message?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants