Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove id from fields if it's an internal id #16

Closed
wolfenmark opened this issue Sep 10, 2021 · 2 comments
Closed

Remove id from fields if it's an internal id #16

wolfenmark opened this issue Sep 10, 2021 · 2 comments

Comments

@wolfenmark
Copy link

Hi,
I found the 'id' field misleading, interpreting it as an id to retrieve the project from the GH API.
Can it be removed if it's only a GHSearch internal identifier?

@wolfenmark
Copy link
Author

Maybe this is the id returned by GH's API. In that case it would be useful to have it. Possibly related to #17.

I tried to use it to retrieve repos in a more reliable way (guessing that an id would remain the same in case of ownership/name changes) but I found inconsistencies (completely different repos returned).

@emadpres
Copy link
Collaborator

As of now, it's an internal ID that needs to be removed, or better, will be replaced with a time-invariant unique ID of repositories as you brought up in #17. So I close this issue and leave #17 opens to address it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants