Skip to content
This repository has been archived by the owner on Sep 7, 2023. It is now read-only.

Fix quoting issue in search_operator plugin #3479

Merged
merged 2 commits into from Apr 5, 2023

Conversation

glanham-jr
Copy link
Contributor

What does this PR do?

Fix the apostrophe issue described in #3414 (read diagnosis there) by using shlex.quote.

Why is this change important?

Fixes a 500 Server Error issue when Search Operator is being used with apostrophes.

How to test this PR locally?

  1. Make a request with an apostrophe (')
  2. Ensure the following cookies are set
enabled_plugins="Search_operators";
disabled_plugins=;

Author's checklist

Related issues

Closes #3414

@kvch
Copy link
Member

kvch commented Apr 4, 2023

Thanks for looking into this issue. Do you mind fixing the error reported by the linter?

@glanham-jr
Copy link
Contributor Author

Thanks for looking into this issue. Do you mind fixing the error reported by the linter?

Fixed

@kvch
Copy link
Member

kvch commented Apr 5, 2023

Thank you!

@kvch kvch merged commit 75b859d into searx:master Apr 5, 2023
7 checks passed
@glanham-jr glanham-jr deleted the fix-search-operator-quote branch April 11, 2023 00:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using single apostrophe causes a "search error"
3 participants