Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] remove form-action 'self' from CSP header (Caddy) #178

Closed
wants to merge 1 commit into from

Conversation

return42
Copy link
Member

@return42 return42 commented Sep 6, 2023

Closes: #177

Closes: searxng#177

Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
@dalf
Copy link
Member

dalf commented Sep 6, 2023

The CSP is safety belt to make sure the user query is not sent to a third party: I prefer to keep it and implement searxng/searxng#140

@mrpaulblack
Copy link
Member

I agree with alex 👍

@return42
Copy link
Member Author

return42 commented Sep 7, 2023

Yes, searxng/searxng#140 is a much better solution ... this PR can only be a workaround for an intermediate solution ... @dalf it's up to you, if you think we better should not merge such a workaround, please close this PR. Since I don't use docker myself this should only be a suggestion / For me it would be fully OK to close the PR.

@dalf
Copy link
Member

dalf commented Sep 7, 2023

I prefer to implement the double redirect as described by @sevmonster and keep the CSP header as it is.

The issue is not about Docker: the CSP header should be set in all SearXNG instances. Also, the installation scripts should set them in the same way ( = not third party can received the query).

[EDIT] there is no need to update the installation scripts ; we "just" need to implement searxng/searxng#140

@dalf dalf closed this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle double-bang redirections better for CSP
3 participants