[fix] filtron.sh: fix filtron proxy error #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morty & filtron upgrade golang from v1.13.5 to v1.17.2 (#stable go[1]) Closes: searxng#443 [1] https://golang.org/dl/#stable
return42
force-pushed
the
fix-filtron-install
branch
from
5fc3e72
to
52e91e7
Compare
return42
approved these changes
Oct 29, 2021
return42
added a commit
to return42/searxng
that referenced
this pull request
Oct 29, 2021
Related-to: 5c4afdd searxng#455 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
return42
added a commit
to return42/searxng
that referenced
this pull request
Oct 29, 2021
Related-to: 5c4afdd searxng#455 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
|
Note: When golang is installed via a package manager the local version, which filtron downloads, is ignored. |
return42
added a commit
to return42/searxng
that referenced
this pull request
Oct 30, 2021
When golang is installed via a package manager the local version, which filtron downloads, is ignored. Reported-by: @tiekoetter searxng#455 (comment) Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
return42
added a commit
to return42/searxng
that referenced
this pull request
Oct 30, 2021
When golang is installed via a package manager the local version, which filtron downloads, is ignored. BTW: With the new go1.17.2 (cfea51f), 'go get' is depricated:: go get: installing executables with 'go get' in module mode is deprecated. Use 'go install pkg@version' instead. For more information, see https://golang.org/doc/go-get-install-deprecation or run 'go help get' or 'go help install'. Reported-by: @tiekoetter searxng#455 (comment) Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
@tiekoetter: thanks for the information, it is fixed in #461 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
build filtron with the golang version 1.17.2
Why is this change important?
#443 is fixed by upgrading the golang version.
How to test this PR locally?
In a new VM:
Author's checklist
Related issues
close #443