Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid insert query for an entity only with auto generated ID column. #18

Closed
bufferings opened this issue Jul 21, 2015 · 1 comment
Closed

Invalid insert query for an entity only with auto generated ID column. #18

bufferings opened this issue Jul 21, 2015 · 1 comment

Comments

@bufferings
Copy link
Contributor

Hi,

It seems that Doma creates wrong insert sql for an entity only with auto generated ID column like this:

insert into ID_ONLY) values)

It might be better to generate following query:

insert into ID_ONLY() values ()

I'm glad if you kindly share your opinion about this issue.
I will send a pull request.
@bufferings bufferings mentioned this issue Jul 21, 2015
Merged
@nakamura-to
Copy link
Contributor

Closed by #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nakamura-to @bufferings