Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split JRuleWhen into multiple triggers #53

Closed
querdenker2k opened this issue Oct 8, 2022 · 4 comments
Closed

Split JRuleWhen into multiple triggers #53

querdenker2k opened this issue Oct 8, 2022 · 4 comments

Comments

@querdenker2k
Copy link
Collaborator

I would suggest to split JRuleWhen into multiple triggers, like JRuleWhenTime, JRuleWhenItem and JRuleWhenChannel to not have such a lot unused annotation functions.
What do you think @seaside1 @seime

@seime
Copy link
Collaborator

seime commented Oct 9, 2022

👍 . Would be a breaking change though and thus need a bit of doc updates.

@seaside1
Copy link
Owner

seaside1 commented Oct 9, 2022

Yes, but maybe we can start with adding these new JRuleWhenXXXX and keep the old one as well. That way we don't break existing rules for people. It also gives more time to test before removing JRuleWhen (if we decide to do so).

@querdenker2k
Copy link
Collaborator Author

I removed the old JRuleWhen because multiple options will let the code be more confusing.

@seaside1
Copy link
Owner

Closing after merge of #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants