-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split JRuleWhen into multiple triggers #53
Comments
👍 . Would be a breaking change though and thus need a bit of doc updates. |
Yes, but maybe we can start with adding these new JRuleWhenXXXX and keep the old one as well. That way we don't break existing rules for people. It also gives more time to test before removing JRuleWhen (if we decide to do so). |
I removed the old JRuleWhen because multiple options will let the code be more confusing. |
Closing after merge of #61 |
I would suggest to split JRuleWhen into multiple triggers, like JRuleWhenTime, JRuleWhenItem and JRuleWhenChannel to not have such a lot unused annotation functions.
What do you think @seaside1 @seime
The text was updated successfully, but these errors were encountered: