Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The second transport icon is too small #114

Open
Altonss opened this issue Jan 31, 2022 · 2 comments
Open

The second transport icon is too small #114

Altonss opened this issue Jan 31, 2022 · 2 comments
Labels
topic: look and feel Improvements and additions to the app's appearance only

Comments

@Altonss
Copy link
Contributor

Altonss commented Jan 31, 2022

Describe the bug
The second transport icon (when there are 2 side by side) is too small in the main view (in the detailed view of 1 item it is okay!).

To Reproduce
Steps to reproduce the behavior:

  1. Go to the main view
  2. See an item that has 2 means of transportation
  3. See error

Expected behavior
The scaling of the second icon should be like on the item view.

Screenshots
image
image

Used device (please complete the following information):

  • Device: Samsung Galaxy Core Prime
  • OS: Android 5.0.1
  • Browser: Fennec F-Droid
  • App Version: 1.4.8+43(f)
@matzebond matzebond added good first issue Issues with a small scope. Ideal for getting familiar with the code base. needs fix: minor Something isn't working or has to be fixed otherwise (details, non-critical problems) topic: look and feel Improvements and additions to the app's appearance only labels Feb 2, 2022
@matzebond
Copy link
Collaborator

Just fund that there is some scaling applied. Looks like the truck icon is supposed to be drawn a little smaller.

children: <Widget>[
Icon(availabilityModeIcons[fstModeIdx],
size: constraint.biggest.height,
color: Colors.black.withAlpha(primaryIconAlpha)),
Text(" / "),
Icon(availabilityModeIcons[sndModeIdx],
size: constraint.biggest.height / 1.4,
color: Colors.black.withAlpha(secondaryIconAlpha)),
],

We will need to decide which way to go about this and use the same layout in both cases.

@matzebond matzebond removed needs fix: minor Something isn't working or has to be fixed otherwise (details, non-critical problems) good first issue Issues with a small scope. Ideal for getting familiar with the code base. labels Feb 20, 2022
@Flunzmas
Copy link
Collaborator

Yeah that scaling actually was intentional, to show that it's the "secondary" availability. However, I'm open to alternatives, because I agree that it does look a bit off this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: look and feel Improvements and additions to the app's appearance only
Projects
None yet
Development

No branches or pull requests

3 participants