Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix undo log sql type bug #495

Merged
merged 1 commit into from
Mar 4, 2023
Merged

fix undo log sql type bug #495

merged 1 commit into from
Mar 4, 2023

Conversation

luky116
Copy link
Contributor

@luky116 luky116 commented Mar 4, 2023

What this PR does:

Which issue(s) this PR fixes:

Fixes #494

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@github-actions github-actions bot added the coding label Mar 4, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #495 (2f5e103) into master (508795b) will increase coverage by 0.32%.
The diff coverage is 42.56%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #495      +/-   ##
==========================================
+ Coverage   38.73%   39.05%   +0.32%     
==========================================
  Files         149      152       +3     
  Lines        9980    10218     +238     
==========================================
+ Hits         3866     3991     +125     
- Misses       5794     5905     +111     
- Partials      320      322       +2     
Impacted Files Coverage Δ
pkg/datasource/sql/at.go 0.00% <0.00%> (ø)
pkg/datasource/sql/exec/at/at_executor.go 0.00% <0.00%> (ø)
pkg/datasource/sql/exec/at/base_executor.go 39.13% <0.00%> (+1.18%) ⬆️
pkg/datasource/sql/exec/at/delete_executor.go 23.23% <0.00%> (ø)
pkg/datasource/sql/exec/at/insert_executor.go 42.03% <0.00%> (ø)
...atasource/sql/exec/at/insert_on_update_executor.go 38.41% <0.00%> (ø)
pkg/datasource/sql/exec/at/multi_executor.go 0.00% <0.00%> (ø)
pkg/datasource/sql/exec/at/multi_update_excutor.go 32.35% <0.00%> (ø)
...tasource/sql/exec/at/select_for_update_executor.go 30.23% <0.00%> (-0.58%) ⬇️
pkg/datasource/sql/exec/at/update_executor.go 25.00% <0.00%> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@georgehao georgehao merged commit 39d8977 into apache:master Mar 4, 2023
@luky116 luky116 deleted the fixSQLType branch March 7, 2023 14:10
georgehao pushed a commit to georgehao/seata-go that referenced this pull request May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

undo log's sql type is invalid
3 participants