Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix the inconsistent configuration item names related to LoadBalance #5233

Merged
merged 9 commits into from Jan 12, 2023

Conversation

xingfudeshi
Copy link
Member

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

fix the inconsistent configuration item names related to LoadBalance

Ⅱ. Does this pull request fix one issue?

fixes #5230

Ⅲ. Why don't you add test cases (unit test/integration test)?

I've provided one.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2023

Codecov Report

Merging #5233 (7d95228) into develop (fc29936) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #5233      +/-   ##
=============================================
- Coverage      48.48%   48.43%   -0.05%     
+ Complexity      4137     4135       -2     
=============================================
  Files            743      743              
  Lines          26520    26520              
  Branches        3294     3294              
=============================================
- Hits           12857    12845      -12     
- Misses         12263    12274      +11     
- Partials        1400     1401       +1     
Impacted Files Coverage Δ
...n/src/main/java/io/seata/common/DefaultValues.java 0.00% <ø> (ø)
...scovery/loadbalance/ConsistentHashLoadBalance.java 89.28% <100.00%> (ø)
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) ⬇️
...rage/redis/store/RedisTransactionStoreManager.java 72.06% <0.00%> (-2.09%) ⬇️
...torage/file/store/FileTransactionStoreManager.java 55.62% <0.00%> (-0.65%) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.76% <0.00%> (+0.73%) ⬆️

@funky-eyes funky-eyes changed the title bugfix:fix the inconsistent configuration item names related to LoadBalance bugfix: fix the inconsistent configuration item names related to LoadBalance Jan 5, 2023
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/seata-spring-boot-starter seata-spring-boot-starter module labels Jan 11, 2023
Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangliang181230
Copy link
Contributor

develop.md里加下日志吧。

@xingfudeshi
Copy link
Member Author

develop.md里加下日志吧。

done

@xingfudeshi xingfudeshi merged commit d19cfee into apache:develop Jan 12, 2023
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangliang181230 wangliang181230 added this to the 1.7.0 milestone Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/seata-spring-boot-starter seata-spring-boot-starter module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inconsistent configuration item names
5 participants