New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix the inconsistent configuration item names related to LoadBalance #5233
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #5233 +/- ##
=============================================
- Coverage 48.48% 48.43% -0.05%
+ Complexity 4137 4135 -2
=============================================
Files 743 743
Lines 26520 26520
Branches 3294 3294
=============================================
- Hits 12857 12845 -12
- Misses 12263 12274 +11
- Partials 1400 1401 +1
|
...oconfigure-client/src/test/java/io/seata/spring/boot/autoconfigure/ClientPropertiesTest.java
Outdated
Show resolved
Hide resolved
...toconfigure-client/src/main/resources/META-INF/additional-spring-configuration-metadata.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
develop.md里加下日志吧。 |
done |
This reverts commit 3c95afe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
fix the inconsistent configuration item names related to LoadBalance
Ⅱ. Does this pull request fix one issue?
fixes #5230
Ⅲ. Why don't you add test cases (unit test/integration test)?
I've provided one.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews