Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: DefaultFailureHandler check status NPE, cause trx finished #1313

Merged
merged 1 commit into from Jul 17, 2019
Merged

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

bugfix: DefaultFailureHandler check status NPE, cause trx finished

Ⅱ. Does this pull request fix one issue?

fix #1312

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jul 16, 2019

Codecov Report

Merging #1313 into develop will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1313      +/-   ##
=============================================
+ Coverage      48.65%   48.67%   +0.01%     
  Complexity      1643     1643              
=============================================
  Files            332      332              
  Lines          11515    11517       +2     
  Branches        1422     1423       +1     
=============================================
+ Hits            5603     5606       +3     
  Misses          5291     5291              
+ Partials         621      620       -1
Impacted Files Coverage Δ Complexity Δ
.../java/io/seata/server/coordinator/DefaultCore.java 59.64% <0%> (-0.71%) 24 <0> (ø)
...server/store/file/FileTransactionStoreManager.java 47.03% <0%> (+1.04%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7584cfd...e8b4142. Read the comment docs.

Copy link
Contributor

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi self-requested a review July 17, 2019 02:05
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DefaultCore.getStatus NPE
5 participants